Implement p2p over public ip #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrix060
force-pushed
the
mario/implement-p2p-over-public-ip
branch
2 times, most recently
from
efef0b8 to
4706a8c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2011 +/- ##
==========================================
- Coverage 75.45% 75.36% -0.09%
==========================================
Files 100 100
Lines 8982 8983 +1
==========================================
- Hits 6777 6770 -7
- Misses 1602 1607 +5
- Partials 603 606 +3 ☔ View full report in Codecov by Sentry. |
derrix060
force-pushed
the
mario/implement-p2p-over-public-ip
branch
2 times, most recently
from
19ca1d9 to
1b6728d
Compare
wojciechos
approved these changes
Aug 6, 2024
kirugan
reviewed
Aug 6, 2024
kirugan
reviewed
Aug 6, 2024
By setting a public address, a machine will be able to gossip it's public address. That's not the best solution because it requires the nodes to tell what's their public ip address, but it will be a temporary measure until other alternatives are being explored.
derrix060
force-pushed
the
mario/implement-p2p-over-public-ip
branch
from
e6a34b6 to
85a8187
Compare
kirugan
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.